-
Notifications
You must be signed in to change notification settings - Fork 34
Make not slow #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BigSpaceships
wants to merge
15
commits into
develop
Choose a base branch
from
make-not-slow
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make not slow #456
+484
−270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costowell
previously approved these changes
Jan 23, 2026
Contributor
costowell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge, ship it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves various logic to speed up loading conditional, especially dashboard
On CSH ethernet
Before: 6.3 seconds
After: 1.4 seconds
On VPN to my home in state college PA (central)
Before: 6.5 seconds
After: 1.5 seconds
(After I thought about this, not sure if the vpn test is doing what I want because I would've thought that I couldn't reach the db since I wouldn't have been on cshnet but idk)
Spring evals page
Before: 35 seconds
After: 1.3 seconds 🎉
Note: I want to profile these on OKD at some point but I have to figure out how to
Why
Conditional was painfully slow to load before, especially when loading a fresh instance, also on okd spring evals was 504ing
Test Plan
Compared all the various stats on dashboard with both spring and fall semester data
What I checked:
/housing)Env Vars
nope
Checklist